fix(davinci-client): fix updater for device registration collector#537
fix(davinci-client): fix updater for device registration collector#537
Conversation
🦋 Changeset detectedLatest commit: 44b9767 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 44b9767
☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (14.18%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
==========================================
- Coverage 18.79% 14.18% -4.62%
==========================================
Files 140 148 +8
Lines 27640 26063 -1577
Branches 980 998 +18
==========================================
- Hits 5195 3697 -1498
+ Misses 22445 22366 -79
🚀 New features to boost your workflow:
|
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
|
Deployed dc2feab to https://ForgeRock.github.io/ping-javascript-sdk/pr-537/dc2feab6fb597e6687e7e4b5de246b9da3808fae branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/journey-client - 0.0 KB (-83.3 KB, -100.0%) 📊 Minor Changes📈 @forgerock/davinci-client - 39.8 KB (+0.0 KB) ➖ No Changes➖ @forgerock/sdk-logger - 1.6 KB 13 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
4a2146d to
44b9767
Compare
JIRA Ticket
Description
For whatever reason, the DeviceRegistrationCollector's updater will not update the collector in our react-davinci sample app. This fixes it and is needed to unblock https://pingidentity.atlassian.net/browse/SDKS-4656
Summary by CodeRabbit