GPII-3120: Improve grade inheritance of the PlatformReporter#618
Open
klown wants to merge 8 commits intoGPII:masterfrom
Open
GPII-3120: Improve grade inheritance of the PlatformReporter#618klown wants to merge 8 commits intoGPII:masterfrom
klown wants to merge 8 commits intoGPII:masterfrom
Conversation
Cherry-picked from bbd5037: GPII-1939: Device Reporter includes screen resolution information - modified the Platform Reporter to be context aware. - modified the Platform Reporter to allow OS contexts to report additional specific information, e.g., screen resolutions.
Cherry-picked from 8026442: GPII-1939: Device Reporter reports additional OS specific information Renmaed the function for getting the OS specific information and fixed spelling.
Cherry picked from 569642d: GPII-1939: Fixed lint error.
Cherry picked from fcdec05: GPII-1939: Simplified context aware features Also, merged upstream GPII master branch into GPII-1939.
Fixed js-doc comments.
|
CI job passed: https://ci.gpii.net/job/universal-tests/903/ |
Member
Author
|
@amb26 I made the changes to do that as part of GPII-1939, but, here, carved out the relevant code. That is, this pull isolates the switch to context awareness for the PlatformReporter. |
|
CI job failed: https://ci.gpii.net/job/universal-tests/1810/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/1826/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the PlatformReporter's
gpii.platform.nativegrade with infusion's context awareness. That is, implement the OS specific (native) functionality via a grade that capitalizes on a windows context, or linux context, or testing context, etc.This pull against universal provides the basis for the switch to context awareness: one of the grade names for the PlatformReporter is "fluid.contextAware". The actual OS specific implementation is done in, for example, the Windows PlatformReporter that implements the "gpii.platformReporter.windows" context. Windows and Linux pull requests forthcoming.