Open
Conversation
* package.xml updated to version 3 to allow conditional dependencies * CMakeLists: cmake_minimum_required set to 3.0.2
First commit did not have all changes
|
Any news on this? Would be great if it could be merged 👍 |
|
Would be great indeed! |
I've used this package with web_video_server in Noetic and everything is working just fine. Waiting for the merge. Thanks |
|
Why hasn't this been merged yet? :( |
|
Please merge 👍 |
roehling
referenced
this pull request
in fkie/async_web_server_cpp
Jan 12, 2021
|
Merged in fkie/async_web_server_cpp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This P/R updates the package to be Noetic-compatible; in particular:
package.xmlnow uses version 3, and has conditional dependencies onpython-websocket/python3-websocketfor tests;This package is required for
web_video_server: RobotWebTools/web_video_server#104