Add GMTParameterError and update source files #4374
Draft
+64
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
reviewed
Jan 28, 2026
seisman
reviewed
Jan 28, 2026
seisman
reviewed
Jan 28, 2026
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Jan 28, 2026
… input update source files to support the new feature
Chuan1937
changed the title
seisman
reviewed
Jan 29, 2026
seisman
reviewed
Jan 29, 2026
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Jan 29, 2026
Comment on lines
+155
to
+160
| if isinstance(required, str): | ||
| required = {required} | ||
| msg.append( | ||
| "Required parameter(s) are missing: " | ||
| f"{', '.join(repr(par) for par in required)}." | ||
| ) |
Member
There was a problem hiding this comment.
Suggested change
| if isinstance(required, str): | |
| required = {required} | |
| msg.append( | |
| "Required parameter(s) are missing: " | |
| f"{', '.join(repr(par) for par in required)}." | |
| ) | |
| if isinstance(required, str): | |
| msg.append(f"Required parameter is missing: {par!r}.") | |
| else: | |
| msg.append( | |
| "Required parameters are missing: " | |
| f"{', '.join(repr(par) for par in required)}." | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GMTParameterError and deprecate GMTInvalidInput.
@seisman
This is the first PR of #4003