-
Notifications
You must be signed in to change notification settings - Fork 6.7k
fix(appengine): remove deprecated py37 datastore sample #13785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
this resolves b/475331956
|
Here is the summary of changes. You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @iennae, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request removes a deprecated sample application that demonstrated the use of Google Cloud Datastore within the App Engine Flexible Environment for Python 3.7 and earlier. The removal of this outdated sample streamlines the repository by eliminating unsupported code, ensuring that the collection of samples remains current and relevant for users. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes a deprecated Datastore sample for the App Engine flexible environment, which was specific to Python 3.7 and earlier. The deletion of the entire sample directory and its contents is appropriate. The changes are straightforward and I have no issues with the file removals. To ensure a complete cleanup, please also remove any lingering references to the deleted sample directory in other repository-level files, such as .github/CODEOWNERS, if any exist.
this resolves b/475331956
Description
Fixes #b/475331956
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)