-
Notifications
You must be signed in to change notification settings - Fork 6.7k
fix: remove deprecated websockets instance #13787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b/475331568
|
Here is the summary of changes. You are about to delete 3 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @iennae, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the relevance and quality of the sample repository by removing a deprecated websockets sample application. The removal targets an older App Engine Flexible Environment example for Python 3.7 and earlier, ensuring that users are directed to current and supported solutions. This action contributes to a cleaner and more manageable codebase. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes a deprecated websockets sample for App Engine flexible environment (Python 3.7 and earlier). The change involves deleting the entire appengine/flexible_python37_and_earlier/websockets directory. This is a straightforward cleanup of an outdated sample, and the changes appear correct and complete. No issues were found.
b/475331568
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)