Skip to content

Add imp catcher and more#903

Merged
GregHib merged 8 commits intomainfrom
imp-catcher
Feb 28, 2026
Merged

Add imp catcher and more#903
GregHib merged 8 commits intomainfrom
imp-catcher

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Feb 28, 2026

  • Add imp catcher quest
  • Add candle seller and lumbridge swamp cave entrance
  • Add beefy bill
  • Add draynor npc dialogues
  • Add lost city adventurers' dialogues
  • Add culinaromancers chest with unlock command

Closes #877

@github-actions
Copy link
Contributor

Qodana for JVM

14 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 11
Unused import directive 🔶 Warning 2
Unnecessary type argument ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

❌ Patch coverage is 18.24324% with 363 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.34%. Comparing base (447f737) to head (a8368d6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...a/misthalin/lumbridge/swamp/LostCityAdventurers.kt 2.85% 68 Missing ⚠️
...tlin/content/area/misthalin/lumbridge/BeefyBill.kt 3.70% 52 Missing ⚠️
...ent/area/misthalin/lumbridge/swamp/CandleSeller.kt 4.08% 47 Missing ⚠️
...t/area/misthalin/lumbridge/swamp/LumbridgeSwamp.kt 2.12% 46 Missing ⚠️
...ntent/area/misthalin/wizards_tower/WizardMizgog.kt 57.57% 31 Missing and 11 partials ⚠️
...n/content/area/misthalin/draynor_village/Martin.kt 8.33% 33 Missing ⚠️
...otlin/content/quest/free/imp_catcher/ImpCatcher.kt 10.71% 25 Missing ⚠️
...tent/area/misthalin/wizards_tower/WizardGrayzag.kt 9.09% 20 Missing ⚠️
...n/content/area/misthalin/draynor_village/Olivia.kt 18.18% 9 Missing ⚠️
...ontent/area/misthalin/draynor_village/Fortunato.kt 20.00% 8 Missing ⚠️
... and 5 more
Additional details and impacted files
Files with missing lines Coverage Δ
game/src/main/kotlin/content/quest/Quest.kt 44.23% <100.00%> (+1.09%) ⬆️
...rld/gregs/voidps/engine/inv/InventoryOperations.kt 8.92% <0.00%> (-0.17%) ⬇️
...main/kotlin/content/area/asgarnia/falador/Doric.kt 6.25% <0.00%> (ø)
...in/content/entity/player/command/PlayerCommands.kt 26.17% <0.00%> (-0.14%) ⬇️
...nt/area/misthalin/draynor_village/ShadyStranger.kt 33.33% <33.33%> (ø)
...area/misthalin/lumbridge/castle/LumbridgeCellar.kt 25.00% <25.00%> (ø)
...ontent/area/misthalin/draynor_village/Fortunato.kt 20.00% <20.00%> (ø)
...n/content/area/misthalin/draynor_village/Olivia.kt 18.18% <18.18%> (ø)
...tent/area/misthalin/wizards_tower/WizardGrayzag.kt 9.09% <9.09%> (ø)
...otlin/content/quest/free/imp_catcher/ImpCatcher.kt 10.71% <10.71%> (ø)
... and 6 more

... and 2 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #903      +/-   ##
============================================
- Coverage     37.48%   37.34%   -0.14%     
- Complexity     7572     7587      +15     
============================================
  Files          1574     1585      +11     
  Lines         61809    62252     +443     
  Branches      15630    15751     +121     
============================================
+ Hits          23168    23249      +81     
- Misses        33440    33790     +350     
- Partials       5201     5213      +12     
Components Coverage Δ
Content 35.01% <18.28%> (-0.19%) ⬇️
Engine 42.45% <0.00%> (-0.01%) ⬇️
Network 60.85% <ø> (-0.04%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit 72845b9 into main Feb 28, 2026
5 checks passed
@GregHib GregHib deleted the imp-catcher branch February 28, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bugs

1 participant