Conversation
Contributor
🔍 Quality Analysis Report
Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variable-length sequences of compound datatypes could not be read or dispalyed due to being unsupported in
compoundTypeIO(). This manifested as displaying ERROR instead of real data, without providing any clear output to the user about the root cause.This PR implements a read path for the VLEN branch in
compoundTypeIO, following the same pattern as for an array of compounds. In order to be able to display in a typical fixed-size table format, each cell displays all entries of a certain member in the vlen sequence as a string. e.g. If the datatype is a sequence of a cmpd type "coord" with fields 'lat' and 'long', there will be two distinct columns 'lat' and 'long'. Each row 'lat' column will contain all the 'lat' values for the sequence in that row, and the same is true for the 'long' cell in each row.