Fix negative quantity validation error on tiered products#1087
Merged
daveearley merged 1 commit intodevelopfrom Mar 15, 2026
Merged
Fix negative quantity validation error on tiered products#1087daveearley merged 1 commit intodevelopfrom
daveearley merged 1 commit intodevelopfrom
Conversation
When initial_quantity_available was set below quantity_sold, the computed quantity_available went negative, causing incorrect validation errors for unrelated tiers sent with quantity=0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quantity_availableto 0 usingGREATEST()in the availability SQL query to prevent negative values wheninitial_quantity_availableis set belowquantity_soldquantity=0(unselected tiers) — these are never used to create order itemsinitial_quantity_availablebelowquantity_soldon a product pricequantity_sold > initial_quantity_availableTest plan