Add -wpc (with parents' children) parameter#157
Merged
worksofliam merged 7 commits intomainfrom Jul 28, 2025
Merged
Conversation
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-wpmakes it generate a makefile that includes parents, but also includes the parents' children and their children - this is way too much for simple builds.We need a new parameter,
-wpc, which determines if parents children should be included in the build.Below is a message from me to a customer about this issue:
I was able to recreate it easily:
But,
-wp(with-parents) does solve the problem partially – which makes sense, because the markdown repo includes the impacted parents by default.The issue is that
-wpis including the children of each parent. Here is the makefile with-wp:Notice that the objects in
allmatch the markdown. But, now the dependency list comes in:It is actually including the children (the required objects) to build each object, which is way more than what the markdown provides.
I will have to see about adding an additional parameter on whether to include these or not.