minor change to avoid warning from ase#22
Open
yury-lysogorskiy wants to merge 3 commits intoICAMS:masterfrom
Open
minor change to avoid warning from ase#22yury-lysogorskiy wants to merge 3 commits intoICAMS:masterfrom
yury-lysogorskiy wants to merge 3 commits intoICAMS:masterfrom
Conversation
on my system (fresh install, ase 3.22.1 ) the relevant part of the
traceback:
```
File "/scratch/AnacondaEnvironments/ml_datasets/lib/python3.9/site-packages/ase/atoms.py", line 731, in get_potential_energy
energy = self._calc.get_potential_energy(self)
File "/scratch/AnacondaEnvironments/ml_datasets/lib/python3.9/site-packages/ase/calculators/calculator.py", line 709, in get_potential_energy
energy = self.get_property('energy', atoms)
File "/scratch/AnacondaEnvironments/ml_datasets/lib/python3.9/site-packages/ase/calculators/calculator.py", line 737, in get_property
self.calculate(atoms, [name], system_changes)
File "/scratch/AnacondaEnvironments/ml_datasets/lib/python3.9/site-packages/pyace/asecalc.py", line 161, in calculate
if self.atoms.number_of_lattice_vectors == 3:
File "/scratch/AnacondaEnvironments/ml_datasets/lib/python3.9/site-packages/ase/utils/__init__.py", line 62, in deprecated_function
warnings.warn(warning)
FutureWarning: Please use atoms.cell.rank instead
```
which is solved with this modification
165dca3 to
f2bf2ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on my system (fresh install, ase 3.22.1 ) the relevant part of the traceback:
which is solved with this modification