Skip to content

refac: update-mapbox-tileset config#2654

Merged
szabozoltan69 merged 2 commits intodevelopfrom
refac/update-mapbox-tileset
Feb 13, 2026
Merged

refac: update-mapbox-tileset config#2654
szabozoltan69 merged 2 commits intodevelopfrom
refac/update-mapbox-tileset

Conversation

@thenav56
Copy link
Member

Addresses

  • Refactor related to update-mapbox-tileset command

Changes

  • replace if/else with TilesetsConfig
  • replace print with self.stdout/self.stderr

@szabozoltan69
Copy link
Contributor

Beautiful clean-up

@thenav56 thenav56 force-pushed the refac/update-mapbox-tileset branch 4 times, most recently from aff48da to 330d53f Compare February 13, 2026 08:13
@thenav56
Copy link
Member Author

Hey @szabozoltan69

I did a bit more refactoring and separated the tileset management logic out of the command.

Changes: 6e9a36c
Here is the base manager:
https://github.com/IFRCGo/go-api/blob/refac/update-mapbox-tileset/mapbox/tilesets/base.py

Here are the tileset managers for each type:
https://github.com/IFRCGo/go-api/blob/refac/update-mapbox-tileset/mapbox/tilesets/managers.py

image image

Why the change?
We were using hardcoded values throughout, which made it difficult to test with non-IFRC accounts (personal account). Now we can use different Mapbox usernames for testing.
This will also be helpful when we work on the geo refactoring later.


When you have time please review this.

@thenav56 thenav56 marked this pull request as ready for review February 13, 2026 08:14
Copy link
Contributor

@szabozoltan69 szabozoltan69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and very useful job, dear @thenav56
I appreciate a lot that those mapbox/admin2/* files are now removed, it was so tedious to use them.

@thenav56 thenav56 force-pushed the refac/update-mapbox-tileset branch from 330d53f to d734356 Compare February 13, 2026 08:37
@szabozoltan69 szabozoltan69 merged commit 79d3ffd into develop Feb 13, 2026
3 checks passed
@szabozoltan69 szabozoltan69 deleted the refac/update-mapbox-tileset branch February 13, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants