Closed
Conversation
Contributor
|
Hi @smeyer-ilias , Before merging it, i have one question regarding the failing checks. Does these need to be addressed as well? |
sKarki999
added a commit
to sKarki999/ILIAS
that referenced
this pull request
Mar 4, 2026
Contributor
Author
|
Hi @sKarki999, sorry I saw you last comment too late. Thanks for fixing the coding style issues. |
sKarki999
added a commit
that referenced
this pull request
Mar 5, 2026
* initial implementation * Search RPC: fixed mail search; fixed boolean; fixed unwrapped xml params * fix PHP code style to pass CI for PR #11109 * Remove the occurence of 'xmlrpc' from docs/configuration/install.md and components/ILIAS/WebServices/RPC/lib/README.md --------- Co-authored-by: Stefan Meyer <meyer@leifos.de>
sKarki999
added a commit
to sKarki999/ILIAS
that referenced
this pull request
Mar 5, 2026
* initial implementation * Search RPC: fixed mail search; fixed boolean; fixed unwrapped xml params * fix PHP code style to pass CI for PR ILIAS-eLearning#11109 * Remove the occurence of 'xmlrpc' from docs/configuration/install.md and components/ILIAS/WebServices/RPC/lib/README.md --------- Co-authored-by: Stefan Meyer <meyer@leifos.de>
sKarki999
added a commit
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal to get rid of the outdated php extension xmlrpc
Implementation has been done by @schmitz-ilias
It does not provide full compatibility to the XML-RPC standard but the is a replacement for xmlrpc_en|decode calls used for
https://mantis.ilias.de/view.php?id=41313