updated the install.md for ILIAS 10#11194
updated the install.md for ILIAS 10#11194rfalkenstein wants to merge 2 commits intoILIAS-eLearning:release_10from
Conversation
rfalkenstein
added
the
documentation
|
Tested the tar part in the "Get the Code" part and it works fine. |
bogenschlag
left a comment
bogenschlag
left a comment
There was a problem hiding this comment.
Paar kleine Ergänzungen. Scheint mir erstmal ok soweit ansonsten.
rfalkenstein
assigned
rfalkenstein,
fwolf-ilias and
acgruber and unassigned
rfalkenstein
|
I hand this over to @fwolf-ilias and @acgruber for final review/merge :-) |
| ```shell | ||
| php cli/setup.php migrate | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Why was this part removed? It's not very likely, but it has happened before. The default data in the template isn't always updated to include all new migrations.
There was a problem hiding this comment.
Hi @fwolf-ilias , I never noticed that during a new install of ILIAS. I removed it since I thought it would tidy up the documentation if the migrations only occur in one place of the documentation (before the update). My intention was to make sure that all migrations are done before a major upgrade. I am happy to re-add it if you consider it necessary. Just give me a short hint please.
| ``` | ||
|
|
||
| To check if there are migrations, run in your ILIAS folder. | ||
| Please make sure to check for migrations before you run the update. If there are migrations left |
There was a problem hiding this comment.
In my opinion, this is completely wrong. The structure of the database must correspond to the expectations of the code at all times. This also applies to the migration code. If the migrations are executed beforehand and access the database, what structure does the migration step expect? Without an update, there are endless possibilities; after the update, there is only one (that of the current status defined by the update steps).
There was a problem hiding this comment.
As I said earlier my intention was to make sure that all migrations are run before a major upgrade. If I understand you correctly the proposal would be to run all migrations after an update but also before an update? What occured to me from time to time was that migrations are increasing without doing an update.
| consider subscribing to the [ILIAS Admin Mailing-List](https://lists.ilias.de/postorius/lists/ilias-admins.lists.ilias.de/). Information on the | ||
| new versions, such as Important Changes, Known Issues, Changed Behaviour and Fixed | ||
| Issues, can be found in the release notes in [Download & Releases](https://docu.ilias.de/go/lm/35). | ||
| Issues, can be found in the release notes in [Download & Releases](https://docu.ilias.de/go/pg/197850_35). |
There was a problem hiding this comment.
I don't want to change that link after every update. The old link references the complete Download & Releases object, the new link a sub page of this object which is outdated rather quickly.
There was a problem hiding this comment.
As soon as ILIAS 11.0 stable arrives the link will show to this, right? I thought it would be good if each link points to the first stable release of each version. On the other hand I can well understand that there's a need for a permanent link. I'll leave this decision up to you. I'm fine with either way.
|
Thank you for the revision and corrections. Most of the edits are perfectly fine and important. There are three edits, which needs to be discussed, before merging it. |
rfalkenstein
left a comment
rfalkenstein
left a comment
There was a problem hiding this comment.
Hi @fwolf-ilias , thanks for your feedback. Just let me know which of these changes you still consider necessary and I'll happily commit them.
| ```shell | ||
| php cli/setup.php migrate | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Hi @fwolf-ilias , I never noticed that during a new install of ILIAS. I removed it since I thought it would tidy up the documentation if the migrations only occur in one place of the documentation (before the update). My intention was to make sure that all migrations are done before a major upgrade. I am happy to re-add it if you consider it necessary. Just give me a short hint please.
| ``` | ||
|
|
||
| To check if there are migrations, run in your ILIAS folder. | ||
| Please make sure to check for migrations before you run the update. If there are migrations left |
There was a problem hiding this comment.
As I said earlier my intention was to make sure that all migrations are run before a major upgrade. If I understand you correctly the proposal would be to run all migrations after an update but also before an update? What occured to me from time to time was that migrations are increasing without doing an update.
| consider subscribing to the [ILIAS Admin Mailing-List](https://lists.ilias.de/postorius/lists/ilias-admins.lists.ilias.de/). Information on the | ||
| new versions, such as Important Changes, Known Issues, Changed Behaviour and Fixed | ||
| Issues, can be found in the release notes in [Download & Releases](https://docu.ilias.de/go/lm/35). | ||
| Issues, can be found in the release notes in [Download & Releases](https://docu.ilias.de/go/pg/197850_35). |
There was a problem hiding this comment.
As soon as ILIAS 11.0 stable arrives the link will show to this, right? I thought it would be good if each link points to the first stable release of each version. On the other hand I can well understand that there's a need for a permanent link. I'll leave this decision up to you. I'm fine with either way.
4 participants
This is a renewal of the current install.md for ILIAS 10 which seems to miss some things. When this is merged we should also
To be honest I haven't tried the tar.gz checkout yet. Maybe anyone knows about this and can add some feedback? I'll collect all feedback and renew the PR afterwards.
Thanks in advance to everybody involved.