Skip to content

NW 46576: Removes plus symbols from title of media objects in news timeline #11195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matheuszych wants to merge 2 commits into
base: release_11
Choose a base branch
from
Open

NW 46576: Removes plus symbols from title of media objects in news timeline #11195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a86a718
Removes plus symbols from title of media objects in news timeline
matheuszych Dec 16, 2025
ea55f6d
Moves ilObjMediaObject initialization to constructor of ilNewsTimelin…
matheuszych Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 21 additions & 23 deletions components/ILIAS/News/classes/class.ilNewsTimelineItemGUI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ class ilNewsTimelineItemGUI implements ilTimelineItemInt
*/
protected array $item_modal = [];

protected readonly ilObjMediaObject $media_object;

protected function __construct(
protected readonly NewsItem $news_item,
protected readonly ilLikeGUI $like_gui
Expand All @@ -63,6 +65,7 @@ protected function __construct(
->internal()
->gui();
$this->notes = $DIC->notes();
$this->media_object = new ilObjMediaObject($this->news_item->getMobId());
}

public static function getInstance(
Expand Down Expand Up @@ -136,7 +139,7 @@ public function render(): string

// media
if ($this->news_item->getMobId() > 0 && ilObject::_exists($this->news_item->getMobId())) {
$media = $this->renderMedia($this->news_item);
$media = $this->renderMedia();
$tpl->setCurrentBlock("player");
$tpl->setVariable("PLAYER", $media);
$tpl->parseCurrentBlock();
Expand Down Expand Up @@ -198,25 +201,25 @@ public function render(): string
return $tpl->get();
}

protected function renderMedia(NewsItem $i): string
protected function renderMedia(): string
{
$media_path = $this->getMediaPath($i);
$media_path = $this->getMediaPath();
$mime = ilObjMediaObject::getMimeType($media_path);

$ui_factory = $this->gui->ui()->factory();
$ui_renderer = $this->gui->ui()->renderer();

if (in_array($mime, ["image/jpeg", "image/svg+xml", "image/gif", "image/png"])) {
if (isset($this->item_image[$i->getId()]) && isset($this->item_modal[$i->getId()])) {
$image = $this->item_image[$i->getId()];
if (isset($this->item_image[$this->news_item->getId()]) && isset($this->item_modal[$this->news_item->getId()])) {
$image = $this->item_image[$this->news_item->getId()];
} else {
$title = basename($media_path);
$title = $this->media_object->getTitle();
$image = $ui_factory->image()->responsive($media_path, $title);
$modal_page = $ui_factory->modal()->lightboxImagePage($image, $title);
$modal = $ui_factory->modal()->lightbox($modal_page);
$image = $image->withAction($modal->getShowSignal());
$this->item_image[$i->getId()] = $image;
$this->item_modal[$i->getId()] = $modal;
$this->item_image[$this->news_item->getId()] = $image;
$this->item_modal[$this->news_item->getId()] = $modal;
}
$html = $ui_renderer->render($image);
} elseif (in_array($mime, ["video/mp4", "video/youtube", "video/vimeo"])) {
Expand All @@ -226,7 +229,7 @@ protected function renderMedia(NewsItem $i): string
$audio = $ui_factory->player()->audio($media_path);
$html = $ui_renderer->render($audio);
} elseif (in_array($mime, ["application/pdf"])) {
$this->ctrl->setParameterByClass(ilNewsTimelineGUI::class, "news_id", $i->getId());
$this->ctrl->setParameterByClass(ilNewsTimelineGUI::class, "news_id", $this->news_item->getId());
$link = $ui_factory->link()->standard(
basename($media_path),
$this->ctrl->getLinkTargetByClass(ilNewsTimelineGUI::class, "downloadMob")
Expand All @@ -239,29 +242,29 @@ protected function renderMedia(NewsItem $i): string
return $html;
}

protected function renderMediaModal(NewsItem $i): string
protected function renderMediaModal(): string
{
$ui_factory = $this->gui->ui()->factory();
$ui_renderer = $this->gui->ui()->renderer();

if (isset($this->item_image[$i->getId()]) && isset($this->item_modal[$i->getId()])) {
$modal = $this->item_modal[$i->getId()];
if (isset($this->item_image[$this->news_item->getId()]) && isset($this->item_modal[$this->news_item->getId()])) {
$modal = $this->item_modal[$this->news_item->getId()];
return $ui_renderer->render($modal);
}

$media_path = $this->getMediaPath($i);
$media_path = $this->getMediaPath();
$mime = ilObjMediaObject::getMimeType($media_path);

$modal_html = "";

if (in_array($mime, ["image/jpeg", "image/svg+xml", "image/gif", "image/png"])) {
$title = basename($media_path);
$title = $this->media_object->getTitle();
$image = $ui_factory->image()->responsive($media_path, $title);
$modal_page = $ui_factory->modal()->lightboxImagePage($image, $title);
$modal = $ui_factory->modal()->lightbox($modal_page);
$image = $image->withAction($modal->getShowSignal());
$this->item_image[$i->getId()] = $image;
$this->item_modal[$i->getId()] = $modal;
$this->item_image[$this->news_item->getId()] = $image;
$this->item_modal[$this->news_item->getId()] = $modal;
$modal_html = $ui_renderer->render($modal);
}
return $modal_html;
Expand Down Expand Up @@ -301,13 +304,8 @@ public function renderFooter(): string
return $html . $this->renderMediaModal($this->news_item);
}

protected function getMediaPath(NewsItem $i): string
protected function getMediaPath(): string
{
$media_path = "";
if ($i->getMobId() > 0) {
$mob = new ilObjMediaObject($i->getMobId());
$media_path = $mob->getStandardSrc();
}
return $media_path;
return $this->news_item->getMobId() > 0 ? $this->media_object->getStandardSrc() : "";
}
}