Skip to content

[FIX] #27934 UI: Moves html footer element outside of the main element making it its sibling element #11196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matheuszych wants to merge 1 commit into
base: release_11
Choose a base branch
from
Open

[FIX] #27934 UI: Moves html footer element outside of the main element making it its sibling element #11196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions components/ILIAS/UI/src/templates/default/Layout/tpl.standardpage.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,18 +65,19 @@
{MAINBAR}
</div>

<!-- html5 main-tag is not supported in IE / div is needed -->
<main class="il-layout-page-content">
<!-- BEGIN content_breadcrumbs -->
<div class="breadcrumbs">
{BREADCRUMBS}
</div>
<!-- END content_breadcrumbs -->
<div class="il-layout-page-content">
<main>
<!-- BEGIN content_breadcrumbs -->
<div class="breadcrumbs">
{BREADCRUMBS}
</div>
<!-- END content_breadcrumbs -->

{CONTENT}
{CONTENT}
</main>

{FOOTER}
</main>
</div>
</div>

<!-- BEGIN js_file -->
Expand Down
28 changes: 18 additions & 10 deletions components/ILIAS/UI/tests/Component/Layout/Page/StandardPageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,9 @@ public function testRenderingWithTitle(): void
</header>
<div class="il-system-infos"></div>
<div class="nav il-maincontrols">MainBar Stub</div>
<main class="il-layout-page-content">some content</main>
<div class="il-layout-page-content">
<main>some content</main>
</div>
</div>
<script>il.Util.addOnLoad(function() {});</script>
</body>
Expand Down Expand Up @@ -326,7 +328,9 @@ public function testRenderingWithRtlLanguage(): void
</header>
<div class="il-system-infos"></div>
<div class="nav il-maincontrols">MainBar Stub</div>
<main class="il-layout-page-content">some content</main>
<div class="il-layout-page-content">
<main>some content</main>
</div>
</div>
<script>il.Util.addOnLoad(function() {});</script>
</body>
Expand Down Expand Up @@ -379,7 +383,9 @@ public function testRenderingWithMetaData(): void
</header>
<div class="il-system-infos"></div>
<div class="nav il-maincontrols">MainBar Stub</div>
<main class="il-layout-page-content">some content</main>
<div class="il-layout-page-content">
<main>some content</main>
</div>
</div>
<script>il.Util.addOnLoad(function() {});</script>
</body>
Expand Down Expand Up @@ -467,13 +473,15 @@ public function testRenderingWithCrumbs(): void
</header>
<div class="il-system-infos"></div>
<div class="nav il-maincontrols">MainBar Stub</div>
<main class="il-layout-page-content">
<div class="breadcrumbs">
<nav aria-label="breadcrumbs_aria_label" class="breadcrumb_wrapper">
<div class="breadcrumb"><span class="crumb"><a href="#">label1</a></span><span class="crumb"><a href="#">label2</a></span><span class="crumb"><a href="#">label3</a></span></div>
</nav>
</div>some content
</main>
<div class="il-layout-page-content">
<main>
<div class="breadcrumbs">
<nav aria-label="breadcrumbs_aria_label" class="breadcrumb_wrapper">
<div class="breadcrumb"><span class="crumb"><a href="#">label1</a></span><span class="crumb"><a href="#">label2</a></span><span class="crumb"><a href="#">label3</a></span></div>
</nav>
</div>some content
</main>
</div>
</div>
<script>il.Util.addOnLoad(function() {});</script>
</body>
Expand Down