GLOWS - Add packet file name to L1B data#2761
Open
sdhoyt wants to merge 14 commits intoIMAP-Science-Operations-Center:devfrom
Open
GLOWS - Add packet file name to L1B data#2761sdhoyt wants to merge 14 commits intoIMAP-Science-Operations-Center:devfrom
sdhoyt wants to merge 14 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
to the L1B products. All pytests pass, but still need to look at the actual CDF files to verify the new variables are correct.
for L1a string/single element attributes: ground_software_version, pkts_file_name, and flight_software_version.
with new variables. Need to refactor tests after validating CDFs.
product. Still need to refactor test code. Validated CDF file output with Matlab using this code to generate L1a and L1b Histogram data from 20260125.
Re-validated good CDF files with the updated code using MATLAB and flight 20260125 data.
Successfully generated new l1a and l1b histogram products (CDFs) and validated with MATLAB. Passing all existing GLOWS l1a and L1b tests.
tech3371
reviewed
Mar 4, 2026
Contributor
tech3371
left a comment
tech3371
left a comment
There was a problem hiding this comment.
I have one major suggestion which might change remaining changes in this PR.
Sean, it might be helpful to add Maxine or few others besides David to get you quicker review in the future.
AI to help re-order all attributes in the GLOWS YAML files.
pkts_file_name and ground_software_version variables in both the imap_glows_l1a_variable_attrs.yaml and imap_glows_l1b_variable_attrs.yaml files, as these variables are not meant to be plotted and the DISPLAY_TYPE attribute is not necessary.
tech3371
approved these changes
Mar 4, 2026
Contributor
tech3371
left a comment
tech3371
left a comment
There was a problem hiding this comment.
I would still check with GLOWS if they like those to be global attrs but if they don't, then current changes looks good to me. Only minor comments for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
This PR has not been tested yet, but has code to pull the packet file name from the L1B Parent global attribute and create a variable in the L1B datasets. It also contains the metadata for the missing fields in L1B and L2. I'm dropping this ticket since the rest is not metadata related.
This partially implements ticket #2340