BUG: CoDICE L2 Hi-sectored bug#2793
Open
tech3371 wants to merge 3 commits intoIMAP-Science-Operations-Center:devfrom
Open
BUG: CoDICE L2 Hi-sectored bug#2793tech3371 wants to merge 3 commits intoIMAP-Science-Operations-Center:devfrom
tech3371 wants to merge 3 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes CoDICE L2 HI-sectored spin_angle shape/data mismatch (issue #2792) by adjusting how elevation angles are shaped before combining with the base angles, and updates the HI-sectored L2 validation test to accommodate the corrected behavior.
Changes:
- Adjust
process_hi_sectored()spin-angle calculation to use an elevation-angle array shaped like the final dataset before adding the base angle. - Update HI-sectored L2 validation test to skip
spin_anglecomparison due to outdated validation data.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
imap_processing/codice/codice_l2.py |
Updates spin_angle computation logic for HI-sectored L2 output. |
imap_processing/tests/codice/test_codice_hi_l2.py |
Adjusts validation assertions to avoid failing due to outdated spin_angle reference data. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
refactor for easier code reading Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
closes #2792
Overview
I was not setting elevation angle to the same shape as the final dataset before adding the base angle. Due to that, I was behind on updates to it compared to Joey's.
File changes
Testing