feat: improve terminal text readability with better background detection#14
Open
andymccutcheon wants to merge 1 commit intoIterable:mainfrom
Open
Conversation
Enhance terminal background detection and update color choices for better contrast and readability across different terminal environments. Changes: - Improved isDarkBackground() detection with more robust terminal detection - Changed fallback to assume LIGHT backgrounds (safer default) - Added support for NO_COLOR environment variable - Added detection for Hyper and Warp terminals - Updated all color choices to use brighter colors on dark backgrounds: - Link colors: sky-300 (#7DD3FC) on dark, sky-700 (#0369A1) on light - Muted text: gray-200 (#E5E7EB) on dark, gray-700 (#374151) on light - Applied consistent color updates across all UI functions: - formatKeyValue() - showSection() - showCompletion() - showDivider() - formatKeychainChoiceLabel() This fixes the issue where dark blue text was nearly invisible on dark terminal backgrounds, particularly affecting the setup wizard output. Users can still override detection with ITERABLE_UI_THEME=dark or ITERABLE_UI_THEME=light environment variable. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves terminal text readability by enhancing background detection
and using brighter colors on dark terminal backgrounds.
Problem
Dark blue text in the setup wizard was nearly impossible to read on
dark terminal backgrounds, particularly affecting labels like "Selected
endpoint:", "User PII Access:", etc.
Solution
Enhanced Terminal Detection:
isDarkBackground()function with better heuristicsImproved Color Contrast:
light
Updated Functions:
formatKeyValue()- Key-value pair formattingshowSection()- Section headersshowCompletion()- Completion messagesshowDivider()- DividersformatKeychainChoiceLabel()- Key selection listsTesting