-
Notifications
You must be signed in to change notification settings - Fork 56
spack-stack 2.0 container configs. #1902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ashley314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
|
I assume we don't merge this back to develop, since you will redo the containers for the 2.1 release? |
|
@climbfuji Correct - Correct, no need to merge back to develop. I'm just checking this in because I want to keep tabs on the configs we are using for the active CI containers (also I didn't include the errata in the first PR, and I should have, I want it written down somewhere and ths PR feels good enough) |
|
Ready to merge? |
|
I'm running a final test of these containers right now then I'll merge |
This pull request is checking a revision to the release 2.0 containers necessary to remove
sp. Because gsibec brings in sp, we will have to configure jedi-ci to build sp. JCSDA-internal/jedi-ci#56Issues
#1330
JCSDA-internal/jedi-ci#53
Erata notes
These container configs require manual modification of the Docker files in order for their builds to complete. This final modification could be avoided by updating
_spack_checkout_configand the bootstrap template in our fork of spack (or potentially via other unconsidered config customizations) but since we plan to deprecate the spack containers in favor of a tier_1 container site, I'm submitting this as-is simply to ensure the history is captured.Dockerfile fix instrucitons
spack containerizeENVdeclaration on line 4 of the dockerfile add the variableSPACK_STACK_DIR=/opt/spack-stackLive containers.
These containers have been pushed with the following "revision 1" tag suffixes.
747101682576.dkr.ecr.us-east-2.amazonaws.com/jjedi-oneapi-impi-dev:2.0r1747101682576.dkr.ecr.us-east-2.amazonaws.com/jedi-gcc-openmpi-dev:2.0r1747101682576.dkr.ecr.us-east-2.amazonaws.com/jedi-gcc-openmpi-dev:2.0-gcc11r1Checklist