Open
Conversation
fixed an issue where the player could go in the negatives when browsing the shop menu
added reference to harmonylib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I buckled down and removed harmony patching. this is now closer to your workflow :P
OptionsMenuScreen.cs : QoL menu button
GameSettingsScreen.cs : QoL menu detection and initialization
QoLSettingsMenu.cs : menu building logic
GameplayScreen.cs : cutscene and dialogue skip as well as stack cap
ItemManipulator.cs : stack cap on item pickup
ShopMenuScreen.cs : stack cap in shop
ToastPopupScreen.cs : toast speed and movement block
Screen.cs : added HandleInput(InputState input) as a virtual method to the base Screen class, mirroring the existing Update virtual method, so derived screens can hook into the input handling phase.
ScreenManager.cs: updated UpdateScreens to call screen.HandleInput(input) before screen.Update so hooked screens can respond to input in the same frame as the game's own input processing.
currently 1 issue i need to quash is this: waze3174#1
due to the way the stack cap is hardcoded in the shop, the solution i came up with was to check every frame if the player tried to advance past 9. and let them according to stack cap parameters. and vice versa when decrementing back to 9
but what i did caused the listed issues to crop up. i managed to fix the negative count pretty easily. but purchasing when above 9 of a given item is very difficult