fix(vnc): increase VNC and XServer timeouts for macOS/ARM64#266
Open
Dev-sh21 wants to merge 2 commits intoJdeRobot:humble-develfrom
Open
fix(vnc): increase VNC and XServer timeouts for macOS/ARM64#266Dev-sh21 wants to merge 2 commits intoJdeRobot:humble-develfrom
Dev-sh21 wants to merge 2 commits intoJdeRobot:humble-develfrom
Conversation
javizqh
requested changes
Feb 14, 2026
Member
javizqh
left a comment
javizqh
left a comment
There was a problem hiding this comment.
Only missing a inline documentation change
Dev-sh21
force-pushed
the
fix/macos-vnc-timeout
branch
from
e5ae0ad to
0a0610c
Compare
javizqh
requested changes
Feb 14, 2026
| super().__init__() | ||
| self.update_callback = callback | ||
| self.server = WebsocketServer(port=port, host="127.0.0.1") | ||
| self.server = WebsocketServer(port=port, host="0.0.0.0") |
Author
There was a problem hiding this comment.
sir, i have reverted the host bindings to 127.0.0.1, the other changes are in place, please check it once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi @jmplaza @javizqh
this pr address the stability issue, preventing the robotics acadamy from starting on mac os with apple silicon (m1,m2,m3),
for all these devices, the docker container runs under QEMU Emulation which introduces significant performance overhead around 10 times slower than naive x86 and the current hardcoded timeouts are insufficnent for this environment.
As the result the application continously crashes with TimeoutError, before the simulation can finish loading
to solve this, i have increased the timeout to accomodate the emulation overload
this works reliabely on macos ans has no negative impact on native Linux users.