Img processing/add sun detector#105
Open
TziporaGoldshmidt wants to merge 4 commits intoimg_processing_mainfrom
Open
Img processing/add sun detector#105TziporaGoldshmidt wants to merge 4 commits intoimg_processing_mainfrom
TziporaGoldshmidt wants to merge 4 commits intoimg_processing_mainfrom
Conversation
ChedvaErblich
requested changes
Oct 8, 2024
Collaborator
ChedvaErblich
left a comment
ChedvaErblich
left a comment
There was a problem hiding this comment.
Please have someone else review the code, and after she approves it, I'll push it in.
img_processing/src/manager.cpp
Outdated
| @@ -1,8 +1,12 @@ | |||
| #define NUM_OF_TRACKING 10 | |||
Collaborator
There was a problem hiding this comment.
This isn't directly related, but it caught my eye. Define should be placed after include,. Please make this change in a separate commit.
Collaborator
There was a problem hiding this comment.
Do we want to add this video? It's heavy to upload all videos, we should save the videos local...
Do you want it for your tests?
TziporaGoldshmidt
force-pushed
the
img_processing/add-sun-detector
branch
from
4b1bab5 to
0c0f732
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.