Merged
Conversation
mikes-lunarg
force-pushed
the
__release-1.4.345
branch
from
13e7f09 to
50e1981
Compare
mikes-lunarg
force-pushed
the
__release-1.4.345
branch
from
50e1981 to
fbd6ba8
Compare
ziga-lunarg
approved these changes
Mar 6, 2026
charles-lunarg
approved these changes
Mar 6, 2026
| - uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: '3.10' | ||
| - run: python3 -m pip install pyparsing |
Contributor
Author
There was a problem hiding this comment.
reg.py grew a dependency this release: KhronosGroup/Vulkan-Headers@74d8a6c#diff-2b41eb9eae3a737187dbb3feb1e536b9ed7b947497533d48f8ecd6365eeaccb4R17-R18
Comment on lines
-26
to
-36
| - name: Set up Python 3.8 | ||
| if: matrix.os != 'macos-latest' | ||
| uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: '3.8' | ||
| # MacOS machine can run on arm64 and it doesn't support 3.8 | ||
| - name: Set up Python 3.10.11 | ||
| if: matrix.os == 'macos-latest' | ||
| uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: '3.10.11' |
Collaborator
There was a problem hiding this comment.
I take it this is no longer necessary?
Contributor
Author
There was a problem hiding this comment.
I'm not sure why this was ever here, python is only needed for the codegen job
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.