Skip to content

feat(ConnectivityFilter): add vtkConnectivityFilter#3436

Open
qianlishun wants to merge 2 commits intoKitware:masterfrom
qianlishun:feature/connectivity-filter
Open

feat(ConnectivityFilter): add vtkConnectivityFilter#3436
qianlishun wants to merge 2 commits intoKitware:masterfrom
qianlishun:feature/connectivity-filter

Conversation

@qianlishun
Copy link

Context

add vtkConnectivityFilter
Use BFS to find connected regions and extract regions

Results

github-1 guthub-2

Changes

only add .js, no .ts

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds example tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not looked closely, but if the algorithm differs from the C++ vtkConnectivityFilter, you would need to come up with a different filter name.

Please :

  • add an index.d.ts file
  • add a screenshot for the example image gallery
  • consider using existing functions such as getCellPoints() and getPointCells().

Thanks !

@qianlishun
Copy link
Author

I have not looked closely, but if the algorithm differs from the C++ vtkConnectivityFilter, you would need to come up with a different filter name.

Please :

  • add an index.d.ts file
  • add a screenshot for the example image gallery
  • consider using existing functions such as getCellPoints() and getPointCells().

Thanks !

The filter has been renamed as BFSConnectivity Filter;
Added index.d.ts and screenshot
The polydata method has been used to replace the original.

Please review.
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants