Handle rearrivals #660
Open
Handle rearrivals #660
+166
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-bpatel
approved these changes
Feb 13, 2026
Contributor
labkey-bpatel
left a comment
labkey-bpatel
left a comment
There was a problem hiding this comment.
Approved, but please see my comments.
|
|
||
| EHR.Server.TriggerManager.registerHandlerForQuery(EHR.Server.TriggerManager.Events.BEFORE_UPSERT, 'study', 'Arrival', function(helper, scriptErrors, row, oldRow) { | ||
|
|
||
| console.log('isRearrival:', row.rearrival); |
Contributor
There was a problem hiding this comment.
do we need to keep this?
| new NIRCRearrivalFormSection() | ||
| )); | ||
|
|
||
| addClientDependency(ClientDependency.supplierFromPath("nirc_ehr/model/sources/Arrival.js")); |
Contributor
There was a problem hiding this comment.
Does it need dependency on Arrival.js?
|
|
||
| for (FormSection s : getFormSections()) | ||
| { | ||
| s.addConfigSource("Arrival"); |
| { | ||
| public NIRCRearrivalFormSection() | ||
| { | ||
| super("study", "arrival", "Rearrivals", "ehr-gridpanel", true, true, true); |
Contributor
There was a problem hiding this comment.
should the query name here be 'rearrival'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Some animals leave and come back. The EHR system doesn't really handle this. This is a work around to allow multiple arrivals and allow protocol/project assignments on animals with multiple arrivals. Some manual data manipulation still required.
Also a housing performedby fix.
Ticket 54440: Unable to have multiple arrivals
Ticket 54425: Housing Add From File Peformed By
Changes