Fixed related to converter util refactoring #7395
Open
+19
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return date.format(value); | ||
| else if (value instanceof Date) | ||
| return defaultDateTimeFormat.format(value).replace('T', ' '); // replace T with whitespace for human readability | ||
| else if (value instanceof Date dateVal) |
Contributor
There was a problem hiding this comment.
This fix seems like good behavior. Is there also a change we can make to ColumnInfo.getConvert() or getJavaClass() to convert to the more specific type?
Contributor
Author
There was a problem hiding this comment.
PropertyType.Date.convert already does DateUtil.getDateOnly, if that's what you mean?
Contributor
There was a problem hiding this comment.
I looked at this a little, I have a PR that changes that method to return java.sql.Date instead of java.util.Date also PropertyType.DATE_TIME convert to return java.util.Timestamp. Haven't run through tests though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The refactoring of ConvertUtils usages caused a few test failures:
This one is due to calculated expression column value being converted when it shouldn't:
BiologicsAPITest.setVectorAliasViaLegacyUI, BiologicsDataClassTest.testAliasMultiValueDisplayColumn
This one is due to both date and datetime fields are now converted to java.util.Date type. In the past, one is converted to java.sql.Date and the other java.util.Date.
End Point Test: Name expressions field name
Related Pull Requests
Changes