GitHub Issue 465: Add auditing capabilities for grid views#7421
Merged
GitHub Issue 465: Add auditing capabilities for grid views#7421
Conversation
cnathe
requested changes
Feb 16, 2026
Contributor
cnathe
left a comment
cnathe
left a comment
There was a problem hiding this comment.
Looks good overall. Just one minor requested change.
| event.setSchemaName(view.getSchema()); | ||
| event.setQueryName(view.getQueryName()); | ||
| event.setCustomViewOwner(view.getCustomViewOwner()); | ||
| event.setInheritable((view.getFlags() & FLAG_INHERITABLE) != 0); |
Contributor
There was a problem hiding this comment.
can you just use the canInherit(flag) method from QueryManager here instead?
Contributor
There was a problem hiding this comment.
I assume we'd also want to track the FLAG_HIDDEN bit in addition to the inheritable bit?
cnathe
approved these changes
Feb 17, 2026
cnathe
reviewed
Feb 17, 2026
| public void delete(User user, CstmView view) | ||
| { | ||
| Container container = ContainerManager.getForId(view.getContainerId()); | ||
| addGridViewAuditEvent(user, container, "Grid view deleted: " + GridViewAuditProvider.getGridViewNameForAudit(view.getName()), view, view, null); |
Contributor
There was a problem hiding this comment.
minor: it seems that all of the calls to addGridViewAuditEvent now call getGridViewNameForAudit when appending the view name to the comment. Thoughts on just passing the comment as the "Grid view " part of the string and appending on the view name within addGridViewAuditEvent?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Related Pull Requests
Changes