Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/dumbster/src/org/labkey/dumbster/DumbsterModule.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
import org.labkey.api.module.CodeOnlyModule;
import org.labkey.api.module.ModuleContext;
import org.labkey.api.settings.AppProps;
import org.labkey.api.util.MailHelper;
import org.labkey.api.util.SmtpTransportProvider;
import org.labkey.api.view.BaseWebPartFactory;
import org.labkey.api.view.Portal;
import org.labkey.api.view.ViewContext;
Expand Down Expand Up @@ -65,7 +67,7 @@ public WebPartView<?> getWebPartView(@NotNull ViewContext portalCtx, @NotNull Po
@Override
public void doStartup(ModuleContext moduleContext)
{
if (AppProps.getInstance().isMailRecorderEnabled())
if (MailHelper.getActiveProvider() instanceof SmtpTransportProvider && AppProps.getInstance().isMailRecorderEnabled())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add this check to DumbsterManager.start to prevent it from being started by other means (e.g. DumbsterController.SetRecordEmailAction. It should log some sort of error also.

DumbsterManager.get().start();
}
}