Closed
Conversation
Collaborator
|
may I know why it was closed? |
Contributor
Author
|
There was a github message saying it was un-mergable because the commits were not signed. |
Contributor
Author
|
Re-opened to see the "Merging is blocked" message |
Collaborator
|
that is some github config. we can take care of them |
Contributor
Author
|
See #278 instead Got commit signing working, made new commit of same changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created
WebSocket.sock_timeoutproperty to be able to usesock.settimeout(self.sock_timeout)for non-blocking reads when a timeout value is provided. When the default value of None is used, the blocking behavior is unchanged.