Alternate method of making temp data folder to account for domain-joined windows accounts #193#194
Open
kieranjol wants to merge 1 commit intoLibraryOfCongress:masterfrom
Open
Alternate method of making temp data folder to account for domain-joined windows accounts #193#194kieranjol wants to merge 1 commit intoLibraryOfCongress:masterfrom
kieranjol wants to merge 1 commit intoLibraryOfCongress:masterfrom
Conversation
Contributor
|
I left a note over on #193 to see if a small adjustment to how permissions from the directory to be bagged are being preserved on the payload directory. I think it's a bad smell that we are relying on a function designated as private. I am less concerned about the security implications since we are eventually setting them to match those of the original directory, and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #193 and uses an alternative method
(os.mkdir) instead oftempfile.mkdtempto work correctly with domain-joined windows accounts with regards to permissions. I'm very open to any other methods of working around this issue!