Include simulations.json in docs deploy#1166
Conversation
Add simulations.json to the CMake install list so it gets deployed to mflowcode.github.io alongside index.html. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
There was a problem hiding this comment.
Pull request overview
Ensures the documentation deployment includes docs/simulations.json so the landing page (and external consumers) can load the extracted simulation showcase data from the published GitHub Pages site.
Changes:
- Adds
docs/simulations.jsonto thecmake install(FILES ...)list underMFC_DOCUMENTATIONso it’s deployed alongsideindex.html.
Sequence DiagramThis PR adds docs/simulations.json to the CMake install list so the docs build and deploy include the JSON file. As a result the hosted site (mflowcode.github.io) serves simulations.json which external sites can fetch to render the simulation gallery. sequenceDiagram
participant Dev
participant CI_Build as "CI / Docs Build (CMake)"
participant Deploy as "Docs Deploy (GitHub Pages)"
participant Host as "mflowcode.github.io"
participant External as "comp-physics.group (consumer)"
Dev->>CI_Build: Commit CMakeLists change (install simulations.json)
CI_Build->>Deploy: Build docs & include simulations.json in install
Deploy->>Host: Publish docs (index.html, 404.html, simulations.json)
External->>Host: GET /simulations.json
Host-->>External: 200 OK (simulations.json)
External->>External: Render simulation cards from JSON
Generated by CodeAnt AI |
|
CodeAnt AI finished reviewing your PR. |
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdded Changes
Sequence Diagram(s)(Skipped — changes are limited to inline data and client-side rendering in a single HTML file, not meeting the multi-component flow requirement.) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Keep simulations.json as a standalone data file for external consumers, but restore the inline array in index.html so the MFC site works locally (file://) and without depending on the JSON being deployed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1166 +/- ##
==========================================
- Coverage 44.07% 44.06% -0.01%
==========================================
Files 70 70
Lines 20431 20431
Branches 1974 1975 +1
==========================================
- Hits 9004 9003 -1
Misses 10291 10291
- Partials 1136 1137 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
User description
Summary
simulations.jsonto the CMake install list so it gets deployed tomflowcode.github.ioalongsideindex.html9e216d8) extracted the inline simulation data todocs/simulations.jsonand updatedindex.htmlto fetch from it, but missed adding it to the CMake install — so it never reaches the deployed siteContext
This enables the group website (
comp-physics.group) to fetch simulation showcase data directly frommflowcode.github.io/simulations.json, keeping both sites in sync without manual maintenance.Test plan
https://mflowcode.github.io/simulations.jsonreturns valid JSONhttps://mflowcode.github.io/still renders simulation cards correctly🤖 Generated with Claude Code
CodeAnt-AI Description
Deploy simulations.json with the site so simulation data is served
What Changed
Impact
✅ simulations.json served at mflowcode.github.io✅ External sites can fetch up-to-date simulation data✅ Simulation gallery renders correctly after docs deploy💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by CodeRabbit