Skip to content

Extend header into iOS safe area #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MSicc merged 1 commit into from
Mar 8, 2026
Merged

Extend header into iOS safe area #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions assets/css/site.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@

html {
scroll-behavior: smooth;
background:
linear-gradient(180deg, #0f172a 0, #0f172a 8rem, #f5f8fb 8rem, #ebf1f7 100%);
}
Comment on lines 26 to 28
Copy link

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes both the html background and body min-height: 100svh. On short pages (content height < viewport height), the canvas below the body can show the browser default background rather than your intended gradient, since the body background won’t necessarily paint the full viewport without a minimum height and the html background is now unset. To avoid visible background seams, keep a viewport-filling min-height on body (or set a background on html), or otherwise ensure the page background paints the full viewport height.

Copilot uses AI. Check for mistakes.

@media (prefers-reduced-motion: reduce) {
Expand All @@ -45,11 +43,9 @@ html {

body {
margin: 0;
min-height: 100svh;
font-family: "Source Sans 3", sans-serif;
color: var(--text);
background:
linear-gradient(180deg, rgba(15, 23, 42, 1) 0, rgba(15, 23, 42, 1) 8rem, rgba(245, 248, 251, 0) 8rem),
radial-gradient(circle at top left, rgba(103, 146, 196, 0.18), transparent 30%),
linear-gradient(180deg, #f5f8fb 0%, #ebf1f7 100%);
}
Comment on lines 44 to 51
Copy link

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes both the html background and body min-height: 100svh. On short pages (content height < viewport height), the canvas below the body can show the browser default background rather than your intended gradient, since the body background won’t necessarily paint the full viewport without a minimum height and the html background is now unset. To avoid visible background seams, keep a viewport-filling min-height on body (or set a background on html), or otherwise ensure the page background paints the full viewport height.

Copilot uses AI. Check for mistakes.
Expand Down Expand Up @@ -531,7 +527,7 @@ h1 {
}

.site-footer {
padding: 2rem 0 calc(3rem + env(safe-area-inset-bottom));
padding: 2rem 0 3rem;
Copy link

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing env(safe-area-inset-bottom) from the footer padding can cause the footer content to sit underneath the iOS home indicator (or other bottom safe-area obstructions), making links/buttons harder to use. Consider restoring a safe-area-aware bottom padding (optionally with a fallback like env(safe-area-inset-bottom, 0px)), or applying the safe-area padding to a footer inner wrapper if you don’t want it to affect the outer footer box.

Suggested change
padding: 2rem 0 3rem;
padding: 2rem 0 calc(3rem + env(safe-area-inset-bottom, 0px));

Copilot uses AI. Check for mistakes.
}

.site-footer__inner {
Expand Down
Loading