Skip to content

Remove drop level gap condition for jewels#697

Draft
ze-dom wants to merge 2 commits intoMUnique:masterfrom
ze-dom:bugfix/remove_jewels_level_drop_gap
Draft

Remove drop level gap condition for jewels#697
ze-dom wants to merge 2 commits intoMUnique:masterfrom
ze-dom:bugfix/remove_jewels_level_drop_gap

Conversation

@ze-dom
Copy link
Contributor

@ze-dom ze-dom commented Feb 19, 2026

Todo

  • UpdatePlugin (after discussion)
  • Comment changes with source references

This fix removes the drop level gap condition for Jewels, Imp, Angel, Uniria, Ale, and Town Portal Scroll, which was preventing these items from dropping by mobs with higher levels than that limit.

Remarks
Let me know your opinion on the following points, as to whether we should add them or not:

  1. Orbs, Scrolls and other skill items seem to have a lower drop rate (zTeamS6.3, emu) than other items. We could create a new drop group for this.
  2. Second and third class excellent items seem to be extra rarer (zTeamS6.3, emu) than other excellent items.
  3. Jewel of Chaos is not as rare as other jewels/Imp/Angel/Uniria/Ale/Town Portal Scroll (zTeamS6.3, emu) (about (3/7)/(1/11)=4.7 times less rare).

Apparently in zTeamS6.3, they moved the jewel item checks somewhere else and mobs didn't drop them. Maybe they sold them in NPC stores or something.

@ze-dom ze-dom changed the title First commit Remove drop level gap condition for jewels Feb 19, 2026
}
else
{
filteredPossibleItems = [.. selectedGroup.PossibleItems.Where(it => it.DropLevel == 0 || (it.DropLevel <= monsterLevel && it.DropLevel > monsterLevel - 12))];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accordint to zTeamS6.3 (1, 2), emu (1, 2), the gap is 18 and not 12. Let me know if you want to change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question... I'm not sure if it is the correct value for all items. This would mean that Items can drop up to Level 5. If I remember correctly, this wasn't possible for all items. E.g. leather boots and gloves dropped until level 5, while other armor parts were limited to 3 or 4.
This 12 is btw at two places, it probably needs a constant, or to defined in ItemDefinition.

Copy link
Member

@sven-n sven-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and simple solution. I had a way more complicated solution in mind, but I like yours more 😅
Please just move this one method to the base class, instead of inheriting every class from Jewels.

/// Initializer for pets.
/// </summary>
public class Pets : InitializerBase
public class Pets : Jewels
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks strange. Can you move the AddItemToJewelItemDrop to InitializerBase instead?

@ze-dom
Copy link
Contributor Author

ze-dom commented Feb 24, 2026

Ok. What about the remarks in the PR description, what do you want to do about those?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants