MDEV-21543: Speed up VARCHAR pad space handling in multibyte collations #4625
+76
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkodinov
added
the
External Contribution
abarkov
requested changes
Feb 11, 2026
Contributor
abarkov
left a comment
abarkov
left a comment
There was a problem hiding this comment.
The change looks good. Please only undo changes in non-relevant lines. Thanks.
| pos2, char_length2)) | ||
| return 1; | ||
| return 1; | ||
| } |
Contributor
There was a problem hiding this comment.
Please don't touch this line. It's not relevant to this change. We'll replace TAB to spaces in a separate change eventually.
| key, char_length_key)) | ||
| return 1; | ||
| return 1; | ||
| } |
Contributor
There was a problem hiding this comment.
Please don't touch this line.
abarkov
requested changes
Feb 11, 2026
Contributor
abarkov
left a comment
abarkov
left a comment
There was a problem hiding this comment.
Please also add a comment. Thanks.
| len2= uint2korr(pos2); | ||
| pos1+= 2; | ||
| pos2+= 2; | ||
| } |
Contributor
There was a problem hiding this comment.
Can you please add a comment here:
/*
We're not using my_ci_strnncollsp_nchars() here for NOPAD collations
because some virtual implementations do not work correctly. For details see:
https://jira.mariadb.org/browse/MDEV-38712
*/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scoped partial optimization, for MDEV-21543, improving PAD SPACE collations for multibyte character sets, for
HA_KEYTYPE_VARTEXT1only, while keeping the old behavior for other cases until MDEV-38712 is resolved. For more info refer to this Zulip topic: #New Members > MDEV-21543 hp_rec_key_cmp suboptimal comparison