Skip to content

Fix + Improvement#229

Merged
Maxlego08 merged 3 commits intoMaxlego08:developfrom
1robie:developement
Mar 6, 2026
Merged

Fix + Improvement#229
Maxlego08 merged 3 commits intoMaxlego08:developfrom
1robie:developement

Conversation

@1robie
Copy link
Collaborator

@1robie 1robie commented Mar 6, 2026

This pull request focuses on improving placeholder support across item components and refactors the placeholder classes for better modularity and consistency. The changes ensure that dynamic values are correctly parsed and displayed in item names, lore, and book content. Additionally, the placeholder-related classes have been moved and their imports updated throughout the codebase.

Placeholder support improvements:

  • Item components now parse and apply placeholders for item names, lore, and book titles/pages, ensuring dynamic content is shown to players. (ItemNameComponent, LoreComponent, WritableBookContentComponent, WrittenBookContentComponent) [1] [2] [3] [4] [5]

Placeholder class refactoring:

  • Placeholder classes (AutoPlaceholder, DistantPlaceholder, LocalPlaceholder, Placeholder) have been moved from the Common module to the API module, and their package names updated accordingly. [1] [2] [3] [4]
  • All references and imports to placeholder classes across the project have been updated to use the new package location, maintaining consistency and preventing import errors. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Bug fix:

  • Corrected the loading of enchantment values in SpigotEnchantmentsItemComponentLoader to use the correct configuration section, preventing potential errors when loading enchantments.

Internal API consistency:

  • Ensured that placeholder expansion registration uses the new package path in the Placeholder.Api implementation, maintaining internal API consistency.

@Maxlego08 Maxlego08 merged commit 79f895a into Maxlego08:develop Mar 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants