Skip to content

fix(reviews): remove status:success from default search query#1022

Merged
mergify[bot] merged 1 commit intomainfrom
devs/jd/worktree-review-conflict/Ief6ce540a050308cc8c893e8fdfecc77adff15bb
Mar 11, 2026
Merged

fix(reviews): remove status:success from default search query#1022
mergify[bot] merged 1 commit intomainfrom
devs/jd/worktree-review-conflict/Ief6ce540a050308cc8c893e8fdfecc77adff15bb

Conversation

@jd
Copy link
Member

@jd jd commented Mar 10, 2026

The status:success filter excludes PRs where any check has a non-success
state, including non-required checks like Mergify dequeue notifications.
This causes valid PRs to disappear from the review list.

Remove the server-side status filter entirely; required checks filtering
will be added client-side via GraphQL in the next commit.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

Copilot AI review requested due to automatic review settings March 10, 2026 20:12
@jd
Copy link
Member Author

jd commented Mar 10, 2026

This pull request is part of a stack:

  1. fix(reviews): remove status:success from default search query (#1022) 👈
  2. feat(reviews): filter PRs by required checks instead of all checks (#1023)

@mergify mergify bot had a problem deploying to Mergify Merge Protections March 10, 2026 20:12 Failure
@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

@mergify mergify bot requested a review from a team March 10, 2026 20:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the default GitHub search query used by the reviews CLI command so that PRs aren’t excluded due to non-required checks reporting a non-success status, improving the completeness of the “pending reviews” list.

Changes:

  • Removes the status:success qualifier from the default --query value for mergify_cli reviews.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

JulianMaurin
JulianMaurin previously approved these changes Mar 10, 2026
@mergify mergify bot requested a review from a team March 10, 2026 20:34
The status:success filter excludes PRs where any check has a non-success
state, including non-required checks like Mergify dequeue notifications.
This causes valid PRs to disappear from the review list.

Remove the server-side status filter entirely; required checks filtering
will be added client-side via GraphQL in the next commit.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Change-Id: Ief6ce540a050308cc8c893e8fdfecc77adff15bb
Claude-Session-Id: d5572357-9198-403e-83f3-1c3d4cb73a99
@jd jd force-pushed the devs/jd/worktree-review-conflict/Ief6ce540a050308cc8c893e8fdfecc77adff15bb branch from c255b6e to d182475 Compare March 10, 2026 20:44
@mergify mergify bot dismissed JulianMaurin’s stale review March 10, 2026 20:44

Pull request has been modified.

@mergify mergify bot deployed to Mergify Merge Protections March 10, 2026 20:44 Active
@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2026

🧪 CI Insights

Here's what we observed from your CI run for d182475.

🟢 All jobs passed!

But CI Insights is watching 👀

@mergify mergify bot merged commit f8f5942 into main Mar 11, 2026
10 checks passed
@mergify mergify bot deleted the devs/jd/worktree-review-conflict/Ief6ce540a050308cc8c893e8fdfecc77adff15bb branch March 11, 2026 09:07
@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2026

Merge Queue Status

  • Entered queue2026-03-11 09:07 UTC · Rule: default
  • Checks passed · in-place
  • Merged2026-03-11 09:07 UTC · at d18247562cc7a18b7dd57050e9ae8988bb652472

This pull request spent 9 seconds in the queue, including 1 second running CI.

Required conditions to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants