Skip to content

revert(reviews): remove reviews command#1025

Merged
mergify[bot] merged 1 commit intomainfrom
devs/jd/worktree-review-conflict/I072bcf9072472715da3d0268402d5e21f816c3fa
Mar 11, 2026
Merged

revert(reviews): remove reviews command#1025
mergify[bot] merged 1 commit intomainfrom
devs/jd/worktree-review-conflict/I072bcf9072472715da3d0268402d5e21f816c3fa

Conversation

@jd
Copy link
Member

@jd jd commented Mar 11, 2026

The reviews command is not Mergify-specific and doesn't belong in this
CLI. Remove the entire reviews module, its tests, and CLI registration.

This reverts the feature added in cf649c4.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

The reviews command is not Mergify-specific and doesn't belong in this
CLI. Remove the entire reviews module, its tests, and CLI registration.

This reverts the feature added in cf649c4.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Change-Id: I072bcf9072472715da3d0268402d5e21f816c3fa
Claude-Session-Id: d5572357-9198-403e-83f3-1c3d4cb73a99
Copilot AI review requested due to automatic review settings March 11, 2026 11:03
@mergify mergify bot deployed to Mergify Merge Protections March 11, 2026 11:03 Active
@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the reviews command from mergify_cli, reverting the previously added “pending reviews” functionality because it’s not Mergify-specific. It deletes the reviews module and associated tests, and unregisters the command from the main CLI entrypoint.

Changes:

  • Removed mergify_cli.reviews (CLI + GitHub GraphQL API helper).
  • Removed mergify_cli/tests/reviews test suite.
  • Unregistered the reviews command from mergify_cli/cli.py.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
mergify_cli/cli.py Removes import/registration of the reviews subcommand from the root CLI.
mergify_cli/reviews/cli.py Deletes the reviews click command implementation.
mergify_cli/reviews/api.py Deletes the GitHub GraphQL logic used by the command.
mergify_cli/reviews/__init__.py Removes the reviews package marker.
mergify_cli/tests/reviews/test_cli.py Deletes tests covering the reviews command behavior.
mergify_cli/tests/reviews/__init__.py Removes the tests package marker.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mergify mergify bot requested a review from a team March 11, 2026 11:05
@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2026

🧪 CI Insights

Here's what we observed from your CI run for 0c5e934.

🟢 All jobs passed!

But CI Insights is watching 👀

@jd jd marked this pull request as ready for review March 11, 2026 12:24
@mergify mergify bot requested a review from a team March 11, 2026 12:44
@mergify mergify bot merged commit 4f813f0 into main Mar 11, 2026
14 checks passed
@mergify mergify bot deleted the devs/jd/worktree-review-conflict/I072bcf9072472715da3d0268402d5e21f816c3fa branch March 11, 2026 12:48
@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2026

Merge Queue Status

  • Entered queue2026-03-11 12:48 UTC · Rule: default
  • Checks passed · in-place
  • Merged2026-03-11 12:48 UTC · at 0c5e9344a27df1817983ce70105a0e363ac4897b

This pull request spent 9 seconds in the queue, including 1 second running CI.

Required conditions to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants