fix(stack): prevent push from deleting branches of similarly-named stacks#1027
Merged
mergify[bot] merged 1 commit intomainfrom Mar 13, 2026
Conversation
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
Contributor
🧪 CI InsightsHere's what we observed from your CI run for 0e36adb. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Pull request overview
This PR addresses an important correctness issue in the stack push flow where GitHub’s head: search filter can prefix-match similarly named stacks (e.g., bybye/... vs bybye-v2/...), leading to incorrect orphan detection and unintended branch deletions/PR closures.
Changes:
- Update the GitHub Search API query to use
head:<stack_prefix>/to narrow matches to the intended stack namespace.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…acks Add trailing slash to GitHub search query `head:` filter to use exact stack prefix matching. Without it, `head:bybye` prefix-matches both `bybye/...` and `bybye-v2/...` branches, causing the orphan detection to incorrectly delete branches and close PRs from other stacks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Change-Id: Ia6735c769299e47991e5df91a596305d41fc49ec
a9ebc7d to
0e36adb
Compare
jd
approved these changes
Mar 13, 2026
JulianMaurin
approved these changes
Mar 13, 2026
Contributor
Merge Queue Status
This pull request spent 7 seconds in the queue, including 1 second running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add trailing slash to GitHub search query
head:filter to use exactstack prefix matching. Without it,
head:bybyeprefix-matches bothbybye/...andbybye-v2/...branches, causing the orphan detectionto incorrectly delete branches and close PRs from other stacks.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com