Skip to content

October 2025 security updated and sonar cloud scanner version bump up #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phaupt merged 2 commits into from
Feb 25, 2026
Merged

October 2025 security updated and sonar cloud scanner version bump up #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfebd1c
October 2025 security updated and sonar cloud scanner version bump up
thomas4v Sep 30, 2025
2bebc0c
Update for sonarcloud config - syntax and indented correctly args
thomas4v Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions .github/workflows/sonarcloud.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ on:
- main
- 'releases/**'
pull_request:
types: [opened, synchronize, reopened]
types: [ opened, synchronize, reopened ]

permissions:
pull-requests: read # allows SonarCloud to decorate PRs with analysis results
Expand All @@ -44,18 +44,19 @@ jobs:
sonarqube:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
# Disabling shallow clones is recommended for improving the relevancy of reporting
fetch-depth: 0
- name: SonarQube Scan
uses: SonarSource/sonarqube-scan-action@v6.0.0 # Ex: v4.1.0, See the latest version at https://github.com/marketplace/actions/official-sonarqube-scan
env:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
- uses: actions/checkout@v4
with:
# Disabling shallow clones is recommended for improving the relevancy of reporting
fetch-depth: 0
- name: SonarQube Scan
uses: SonarSource/sonarqube-scan-action@v6.0.0 # Ex: v4.1.0, See the latest version at https://github.com/marketplace/actions/official-sonarqube-scan
env:
Comment on lines +51 to +53
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description mention a SonarCloud scanner version bump, but this workflow still pins SonarSource/sonarqube-scan-action@v6.0.0 (no version change in this PR). Either update the action version to the intended target, or adjust the PR title/description to reflect that this is primarily a formatting/args change.

Copilot uses AI. Check for mistakes.
# Pass the token securely via environment variable
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
with:
# Additional arguments for the sonarcloud scanner
args:
# Unique keys of your project and organization. You can find them in SonarCloud > Information (bottom-left menu)
# mandatory
args: >
-Dsonar.projectKey=MobileID-Strong-Authentication_mobileid-client-java
-Dsonar.organization=mobileid-strong-authentication
# Unique keys of your project and organization. You can find them in SonarCloud > Information (bottom-left menu)
# mandatory
2 changes: 1 addition & 1 deletion mid-java-client-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>ch.mobileid.mid-java-client</groupId>
<artifactId>mid-java-client-parent</artifactId>
<version>1.5.7</version>
<version>1.5.8</version>
</parent>

<artifactId>mid-java-client-core</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion mid-java-client-rest/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>ch.mobileid.mid-java-client</groupId>
<artifactId>mid-java-client-parent</artifactId>
<version>1.5.7</version>
<version>1.5.8</version>
</parent>

<artifactId>mid-java-client-rest</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion mid-java-client-soap/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>ch.mobileid.mid-java-client</groupId>
<artifactId>mid-java-client-parent</artifactId>
<version>1.5.7</version>
<version>1.5.8</version>
</parent>

<artifactId>mid-java-client-soap</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion mid-java-client-usage/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>ch.mobileid.mid-java-client</groupId>
<artifactId>mid-java-client-parent</artifactId>
<version>1.5.7</version>
<version>1.5.8</version>
</parent>

<artifactId>mid-java-client-usage</artifactId>
Expand Down
10 changes: 5 additions & 5 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>ch.mobileid.mid-java-client</groupId>
<artifactId>mid-java-client-parent</artifactId>
<version>1.5.7</version>
<version>1.5.8</version>
<name>Mobile ID Java client</name>
<description>Mobile ID client reference implementation in Java</description>
<url>https://github.com/MobileID-Strong-Authentication/mobileid-client-java</url>
Expand Down Expand Up @@ -86,7 +86,7 @@
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
<version>2.14.0</version>
<version>2.16.1</version>
</dependency>
<dependency>
<groupId>commons-codec</groupId>
Expand All @@ -113,17 +113,17 @@
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk18on</artifactId>
<version>1.78</version>
<version>1.80</version>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcpkix-jdk18on</artifactId>
<version>1.78.1</version>
<version>1.80</version>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcutil-jdk18on</artifactId>
<version>1.78.1</version>
<version>1.80</version>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
Expand Down
Loading