Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
PR fixes several PowerDNS integration issues by aligning runtime configuration with generated API keys, sourcing the DNS domain from RootDSE, and adjusting zone listing behavior; it also removes an obsolete BIND→PDNS migration manager module.
Changes:
- Filter “default” zones from the PowerDNS Recursor forward-zones listing.
- Use RootDSE as the source of truth for the DNS domain when building
DNSSettingsDTO. - Remove the old
BindToPDNSMigrationManagerand update packaging compose to mountpdns.confdirectly.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/ldap_protocol/dns/managers/power_dns_manager.py | Adds filtering logic when returning forward zones from the recursor. |
| app/ldap_protocol/dns/managers/bind_to_pdns_migrations_manager.py | Removes the old migration manager implementation. |
| app/ldap_protocol/dns/dns_gateway.py | Changes DNS settings construction to accept domain as an explicit parameter. |
| app/ioc.py | Fetches domain via RootDSE gateway and passes it into DNS settings builder. |
| .package/docker-compose.yml | Mounts ./pdns.conf into the pdns_auth container (enables generated API key config usage). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Naksen
approved these changes
Mar 5, 2026
Naksen
pushed a commit
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Задача: 1341