Skip to content

Bugfix: PowerDNS bugfixes#956

Merged
Naksen merged 6 commits intodevfrom
bugfix/1341_pDNS_bugfixes
Mar 5, 2026
Merged

Bugfix: PowerDNS bugfixes#956
Naksen merged 6 commits intodevfrom
bugfix/1341_pDNS_bugfixes

Conversation

@iyashnov
Copy link
Collaborator

@iyashnov iyashnov commented Mar 4, 2026

Задача: 1341

  1. Теперь при запуске сервиса PowerDNS Auth в контейнер маунтится конфиг со сгенерированным API ключем
  2. Домен теперь берется из rootDSE
  3. При запросе forward-зон отфильтровываются дефолтные зоны
  4. Удален лишний менеджер миграций, который был переименован в use_case (забыл закоммитить удаление в ПРе с миграцией)

Copilot AI review requested due to automatic review settings March 4, 2026 14:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

PR fixes several PowerDNS integration issues by aligning runtime configuration with generated API keys, sourcing the DNS domain from RootDSE, and adjusting zone listing behavior; it also removes an obsolete BIND→PDNS migration manager module.

Changes:

  • Filter “default” zones from the PowerDNS Recursor forward-zones listing.
  • Use RootDSE as the source of truth for the DNS domain when building DNSSettingsDTO.
  • Remove the old BindToPDNSMigrationManager and update packaging compose to mount pdns.conf directly.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
app/ldap_protocol/dns/managers/power_dns_manager.py Adds filtering logic when returning forward zones from the recursor.
app/ldap_protocol/dns/managers/bind_to_pdns_migrations_manager.py Removes the old migration manager implementation.
app/ldap_protocol/dns/dns_gateway.py Changes DNS settings construction to accept domain as an explicit parameter.
app/ioc.py Fetches domain via RootDSE gateway and passes it into DNS settings builder.
.package/docker-compose.yml Mounts ./pdns.conf into the pdns_auth container (enables generated API key config usage).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Naksen Naksen merged commit 0df22cb into dev Mar 5, 2026
6 checks passed
@Naksen Naksen deleted the bugfix/1341_pDNS_bugfixes branch March 5, 2026 07:32
Naksen pushed a commit that referenced this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants