This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Implement Filter & helper functions#42
Merged
benthecarman merged 1 commit intoMutinyWallet:masterfrom Nov 14, 2022
benthecarman:chain-access
Merged
Implement Filter & helper functions#42benthecarman merged 1 commit intoMutinyWallet:masterfrom benthecarman:chain-access
benthecarman merged 1 commit intoMutinyWallet:masterfrom
benthecarman:chain-access
Conversation
AnthonyRonning
approved these changes
Nov 12, 2022
Contributor
AnthonyRonning
left a comment
AnthonyRonning
left a comment
There was a problem hiding this comment.
didn't look too much at chain.rs but the rest looks good and i like the separation of MutinyWallet and MutinyChain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements some of the required stuff for getting blockchain data for ldk. A lot is copied from lightningdevkit/ldk-node#9 and adapted to fit in our use case.
The next step would to get a stream of txs and somehow construct a stream of
lightning::chain::Confirms and callchain.syncon them.Fixed a couple small clippy errors as well