Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors several data conversion and processing scripts for the
bodemlagen_pwn_2024dataset to improve maintainability and reproducibility. The main changes involve replacing hardcoded file paths with dynamic data path resolution, enhancing documentation, and fixing a minor bug in an interpolation helper function.Refactoring and maintainability improvements:
get_abs_data_pathfunction in the following scripts to make them portable and easier to use across environments:_convert_koster_interpretation_shapes_to_geojson.py_convert_boundaries.py_merge_masks.pyDocumentation enhancements:
_convert_koster_interpretation_shapes_to_geojson.pyand_convert_boundaries.pyto clarify the purpose, usage, and context of the conversion scripts. [1] [2]Bug fixes:
interpolation_helper_functions.pywhere a comma was missing between values, ensuring correct neighbor value assignment.Other minor changes:
pyproject.tomlfrom 3.11 to 3.13 for the default environment.botm.pyto remove outdated comments.