Skip to content

Bodemlagen2024 revisited#51

Merged
bdestombe merged 2 commits intomainfrom
bodemlagen2024-revisited
Feb 26, 2026
Merged

Bodemlagen2024 revisited#51
bdestombe merged 2 commits intomainfrom
bodemlagen2024-revisited

Conversation

@bdestombe
Copy link
Member

This pull request refactors several data conversion and processing scripts for the bodemlagen_pwn_2024 dataset to improve maintainability and reproducibility. The main changes involve replacing hardcoded file paths with dynamic data path resolution, enhancing documentation, and fixing a minor bug in an interpolation helper function.

Refactoring and maintainability improvements:

  • Replaced hardcoded file paths with the get_abs_data_path function in the following scripts to make them portable and easier to use across environments:
    • _convert_koster_interpretation_shapes_to_geojson.py
    • _convert_boundaries.py
    • _merge_masks.py

Documentation enhancements:

  • Improved and expanded docstrings in _convert_koster_interpretation_shapes_to_geojson.py and _convert_boundaries.py to clarify the purpose, usage, and context of the conversion scripts. [1] [2]

Bug fixes:

  • Fixed a typo in a dictionary value in interpolation_helper_functions.py where a comma was missing between values, ensuring correct neighbor value assignment.

Other minor changes:

  • Updated the Python version requirement in pyproject.toml from 3.11 to 3.13 for the default environment.
  • Minor code cleanup in botm.py to remove outdated comments.

@bdestombe bdestombe merged commit 53ecab7 into main Feb 26, 2026
1 check failed
@bdestombe bdestombe deleted the bodemlagen2024-revisited branch February 26, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant