Fix and harden attention benchmark script#2671
Draft
KshitijLakhani wants to merge 2 commits intoNVIDIA:mainfrom
Draft
Fix and harden attention benchmark script#2671KshitijLakhani wants to merge 2 commits intoNVIDIA:mainfrom
KshitijLakhani wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
- Add project root to sys.path so tests can be imported from any cwd. - Fix ModelConfig args: use correct order and keywords. - Run benchmark in main process first (append_csv=True) so times.csv is always populated; nsys subprocess uses append_csv=False. Fix subprocess -c to a single string and pass cwd. - Unpack three return values from _run_dot_product_attention (out, max_logit, grads). - Show module timings (FusedAttention/FlashAttention Module) in the summary; display "N/A" for speedup when only one backend ran. - Harden parse_results: configurable kernel name constants, case-insensitive match, skip if trace file missing. Signed-off-by: Kshitij Lakhani <klakhani@nvidia.com>
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: