exec::repeat_until et al.: Dependent Child Sender Support#1879
Open
RobertLeahy wants to merge 1 commit intoNVIDIA:mainfrom
Open
exec::repeat_until et al.: Dependent Child Sender Support#1879RobertLeahy wants to merge 1 commit intoNVIDIA:mainfrom
RobertLeahy wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
The TODO eliminated by this commit not only meant that exec:: repeat_until et al. previously didn't the usual constant evaluation techniques to report errors, it also meant that a hard compile error (rather than a return type indicating that the sender is dependent) resulted if: - The child sender was dependent, and - An attempt was made to determine the completion signatures of the parent without an environment Updated so exec::repeat_until et al. now properly report that they are dependent if their child is dependent.
ericniebler
reviewed
Feb 21, 2026
| // TODO: port this to use constant evaluation | ||
| return __completions_t<__child_of<_Sender>, _Env...>{}; | ||
| using __child_t = __child_of<_Sender>; | ||
| if constexpr (::STDEXEC::__minvocable_q<__completions_t, __child_t, _Env...>) |
Collaborator
There was a problem hiding this comment.
imo, better would be to change __completions_t to always be well-formed and return descriptive errors. best would be to rewrite this function to use consteval instead of TMP.
Collaborator
|
/ok to test 62c7d22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TODO eliminated by this commit not only meant that exec::repeat_until et al. previously didn't the usual constant evaluation techniques to report errors, it also meant that a hard compile error (rather than a return type indicating that the sender is dependent) resulted if:
Updated so exec::repeat_until et al. now properly report that they are dependent if their child is dependent.