ci(style): use bash shell to ensure proper failure#1881
Open
romintomasetti wants to merge 4 commits intoNVIDIA:mainfrom
Open
ci(style): use bash shell to ensure proper failure#1881romintomasetti wants to merge 4 commits intoNVIDIA:mainfrom
romintomasetti wants to merge 4 commits intoNVIDIA:mainfrom
Conversation
Fix dubious ownership. Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
ericniebler
force-pushed
the
clang-tidy-fix
branch
from
0e487ce to
9e5fcc4
Compare
Collaborator
|
i rebased this PR on one that formats some files i missed the first time. i don't know why clang-format is still complaining. |
Contributor
Author
|
The job is using |
Collaborator
|
i use clang-format-21 locally, yes |
Collaborator
|
when i run this locally: git ls-files *.hpp *.h *.cpp *.c | xargs clang-format-21 --dry-run --Werrori get no errors. |
ericniebler
reviewed
Feb 24, 2026
| - run: git config --global --add safe.directory "$GITHUB_WORKSPACE" | ||
| - shell: bash | ||
| run: | | ||
| git ls-files *.hpp *.h *.cpp *.c | xargs clang-format-21 --dry-run --Werror |
Collaborator
There was a problem hiding this comment.
Suggested change
| git ls-files *.hpp *.h *.cpp *.c | xargs clang-format-21 --dry-run --Werror | |
| git ls-files *.hpp *.h *.cpp *.c *.cuh *.cu | xargs clang-format-21 --dry-run --Werror |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dubious ownership.
This is a followup of: