Skip to content

Comments

Merge NetOffive v1.9.8 release to main#463

Open
jozefizso wants to merge 38 commits intomainfrom
releases/netoffice_v1.9.8
Open

Merge NetOffive v1.9.8 release to main#463
jozefizso wants to merge 38 commits intomainfrom
releases/netoffice_v1.9.8

Conversation

@jozefizso
Copy link
Member

No description provided.

jozefizso and others added 30 commits November 1, 2025 14:02
Fixed the `error NU1004: The project's runtime identifiers have changed from. Project's runtime identifiers: win-x86, lock file's runtime identifiers win7-x86.`
To continue releasing bugfixes in the `v1.9` train the `release` workflow is modernized with support for Azure Trusted Signing and NuGet Trusted Publishing.

The workflow will use federated OIDC logins to Azure and NuGet to minimize secret tokens management.

The `nuget-gallery` environment is gated by manual approval, so the second part of the release workflow will run only after the certificate was uploaded to NuGet Gallyer account.
Backports the new `Presentation.AutoSaveOn` property from PR #439 to release v1.9.8 branch
The BuildTools folder contained utilities from the era of targeting
multiple .NET Frameworks (2.0-4.5). These tools are no longer necessary
as the project now uses modern SDK-style projects targeting .NET
Framework 4.6.2.

Removed tools:
- VersionUpdater: Updated .NET Framework versions in project files
- SourceUpdater: Bulk source file updates (referenced SVN)
- SearchAndReplace: Text search and replace tool
- ReferenceAnalyzer: Project reference analyzer

These tools were last modified in 2013-2016 and are not referenced in
any build scripts, CI/CD configuration, or documentation. Modern
alternatives are built into Visual Studio and MSBuild.

Fixes #446

Co-Authored-By: Claude Code Sonnet 4.5
The `azure/trusted-signing-action` was rebranded to `azure/artifact-signing-action`.
@jozefizso jozefizso self-assigned this Feb 21, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f746621cf5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- name: Download NetOffice packages
uses: actions/download-artifact@v7
with:
name: ${{ needs.release.outputs.nuget_packages_artifact_name }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Download the Release package artifact deterministically

The publish job resolves artifact name from ${{ needs.release.outputs.nuget_packages_artifact_name }}, but release is a matrix job (Debug and Release) and that output is populated from steps.build.outputs.nuget_packages_artifact_name per matrix leg. On tag builds those names can differ (Debug keeps a preview suffix while Release does not), and matrix job outputs expose only one final value, so the downloaded artifact can depend on which leg finishes last; this can publish preview/debug packages for a stable tag. Make the publish path consume only the Release leg’s artifact (or remove Debug from package publishing) so the selected artifact is deterministic.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants