docs: restructure README with unified config reference#235
Conversation
Merge duplicated configuration tables (JSON keys in Configuration, env vars in Docker) into one unified reference with Setting, Env Var, Description, and Default columns. Add previously missing settings (prefixURL, paths, customize.*, conversion.retryFailed). Fix conversion.batchSize default from 10 to 1 to match setting.go. Reorder sections for newcomers: Installation → Docker → Pelican → Configuration → Large Recording Support.
Summary of ChangesHello @fank, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request restructures the README to provide a more unified and comprehensive configuration reference, adds missing settings, corrects a default value, and improves the overall organization and clarity of the documentation. The changes aim to make it easier for new users to set up and configure the OCAP Web server, especially when using Docker. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request effectively restructures the README to provide a unified configuration reference, which significantly improves clarity and reduces duplication. The addition of previously missing settings and the reordering of sections enhance the document's usability for newcomers. The changes to the setting.json example are also a good addition. I've identified a few areas for improvement regarding consistency and clarity in the documentation, particularly around default values and environment variable descriptions.
Address review feedback: show explicit `""` for settings that default to empty string (prefixURL, customize.websiteURL, customize.websiteLogo, customize.headerTitle, customize.headerSubtitle).
Use node:24-alpine (LTS) instead of node:25-alpine (non-LTS).
Summary
prefixURL, all path settings (db,data,maps,markers,ammo,fonts,static), allcustomize.*settings, andconversion.retryFailedconversion.batchSizedefault from10to1(matchessetting.go)docker runexample to top of Docker sectioncustomizeblock to examplesetting.jsonTest plan
setting.goare present#volumes) resolve correctly on GitHub