Skip to content

Comments

fix(ui): mission list column alignment and sidebar title wrapping#236

Merged
fank merged 1 commit intomainfrom
fix/mission-list-styling
Feb 24, 2026
Merged

fix(ui): mission list column alignment and sidebar title wrapping#236
fank merged 1 commit intomainfrom
fix/mission-list-styling

Conversation

@fank
Copy link
Member

@fank fank commented Feb 24, 2026

Summary

  • Fix vertical alignment of column headers (Date, Duration, Players, Kills, Tag, Status) in the mission list table
  • Shorten "Total Kills" column label to "Kills" for consistency with other single-word headers
  • Fix long mission names (e.g. [CO-40][Grim]Operation_Judas_Kiss_v4_20260222_205306) overflowing in the detail sidebar — they now wrap instead of causing a scrollbar

Test plan

  • Verify column headers are vertically aligned in the mission list
  • Verify "Kills" column label displays correctly across locales
  • Select a mission with a long name and confirm the sidebar title wraps without horizontal scrollbar

- Add align-items: center to table header grid for vertical alignment
- Shorten "Total Kills" column label to "Kills" across all locales
- Use title case in total_kills translations (CSS handles uppercasing)
- Allow long mission names to wrap in detail sidebar
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fank, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user interface by addressing several display inconsistencies and layout issues. It improves the readability and aesthetics of the mission list table by ensuring proper alignment of headers and standardizing a column label. Additionally, it resolves an overflow problem in the mission detail sidebar, making long mission names display correctly without causing layout disruptions.

Highlights

  • UI Alignment: Vertical alignment of column headers (Date, Duration, Players, Kills, Tag, Status) in the mission list table has been fixed.
  • Label Consistency: The 'Total Kills' column label has been shortened to 'Kills' for consistency with other single-word headers.
  • Sidebar Display: Long mission names in the detail sidebar now wrap instead of overflowing, preventing horizontal scrollbars.
Changelog
  • ui/src/i18n/locales.ts
    • Shortened the 'total_kills' translation from 'TOTAL KILLS' to 'Kills' for English and other locales to improve consistency.
  • ui/src/pages/mission-selector/MissionSelector.module.css
    • Added align-items: center to the .tableHeader style to vertically align column headers in the mission list.
    • Introduced overflow-wrap: break-word and word-break: break-word to the .sidebarTitle style to ensure long mission names wrap correctly in the sidebar.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

Coverage Report for ui

Status Category Percentage Covered / Total
🔵 Lines 78.48%
🟰 ±0%
2878 / 3667
🔵 Statements 75.16%
🟰 ±0%
3749 / 4988
🔵 Functions 75%
🟰 ±0%
1011 / 1348
🔵 Branches 65.39%
🟰 ±0%
1304 / 1994
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
ui/src/i18n/locales.ts 100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
Generated in workflow #135 for commit dfe9435 by the Vitest Coverage Report Action

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request addresses several UI issues, including vertical alignment of column headers, shortening the 'Total Kills' label for consistency, and ensuring long mission names wrap correctly in the detail sidebar. The changes appear to resolve the stated problems effectively. The localization updates for 'total_kills' are consistent across all supported languages, and the CSS modifications for alignment and word wrapping are appropriate.

@fank fank merged commit f51a979 into main Feb 24, 2026
3 checks passed
@fank fank deleted the fix/mission-list-styling branch February 24, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant