fix: add missing @staticmethod to convert_milliseconds_to_seconds #10
Open
Devguru-codes wants to merge 1 commit intoOSIPI:mainfrom
Open
fix: add missing @staticmethod to convert_milliseconds_to_seconds #10Devguru-codes wants to merge 1 commit intoOSIPI:mainfrom
@staticmethod to convert_milliseconds_to_seconds #10Devguru-codes wants to merge 1 commit intoOSIPI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convert_milliseconds_to_secondsinunit_conversion_utils.pyis missing the@staticmethoddecorator, while its counterpartconvert_to_millisecondshas it. This causes silent failures when called from an instance context (as inBaseSequence._extract_common_metadata), whereselfis consumed as thevaluesparameter.Fix
One-line change: add
@staticmethodaboveconvert_milliseconds_to_seconds.File Changed
package/src/pyaslreport/utils/unit_conversion_utils.py+ @staticmethod def convert_milliseconds_to_seconds(values: int | float | list[int | float]) -> int | float | list[int | float]:Before/After Comparison
mainbranch (before fix)selfconsumed asvalues@staticmethodpresentSummary: PASSED=1 FAILED=2
fix/bug-2-missing-staticmethodbranch (after fix)@staticmethodpresentSummary: PASSED=3 FAILED=0
Sanity Checks
convert_to_milliseconds(1.5)convert_milliseconds_to_seconds(1500)convert_milliseconds_to_seconds([15.0, 30.0])Resolves #9